Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Jason Wang
On Fri, Feb 21, 2025 at 4:46 AM Michael S. Tsirkin wrote: > > On Thu, Feb 20, 2025 at 09:00:04PM +0100, Stefano Brivio wrote: > > On Thu, 20 Feb 2025 13:21:33 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Feb 20, 2025 at 05:59:10PM +0100, Stefano Brivio wrote: > > > > On Thu, 20 Feb 202

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Michael S. Tsirkin
On Thu, Feb 20, 2025 at 09:00:04PM +0100, Stefano Brivio wrote: > On Thu, 20 Feb 2025 13:21:33 -0500 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 20, 2025 at 05:59:10PM +0100, Stefano Brivio wrote: > > > On Thu, 20 Feb 2025 10:28:20 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > > > On

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Stefano Brivio
On Thu, 20 Feb 2025 13:21:33 -0500 "Michael S. Tsirkin" wrote: > On Thu, Feb 20, 2025 at 05:59:10PM +0100, Stefano Brivio wrote: > > On Thu, 20 Feb 2025 10:28:20 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jan 24, 2025 at 05:03:27PM +0100, Stefano Brivio wrote: > > > > But I don

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Michael S. Tsirkin
On Thu, Feb 20, 2025 at 05:59:10PM +0100, Stefano Brivio wrote: > On Thu, 20 Feb 2025 10:28:20 -0500 > "Michael S. Tsirkin" wrote: > > > On Fri, Jan 24, 2025 at 05:03:27PM +0100, Stefano Brivio wrote: > > > But I don't understand why we're leaving this as it is. > > > > So that people notice i

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Stefano Brivio
On Thu, 20 Feb 2025 10:28:20 -0500 "Michael S. Tsirkin" wrote: > On Fri, Jan 24, 2025 at 05:03:27PM +0100, Stefano Brivio wrote: > > But I don't understand why we're leaving this as it is. > > So that people notice if there's some backend problem and > announcements are not going out. should h

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-02-20 Thread Michael S. Tsirkin
On Fri, Jan 24, 2025 at 05:03:27PM +0100, Stefano Brivio wrote: > But I don't understand why we're leaving this as it is. So that people notice if there's some backend problem and announcements are not going out. should help debug migration issues. which we had, so we added this :)

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-24 Thread Stefano Brivio
[Cc'ed Thibaut as author of 3e866365e1eb ("vhost user: add rarp sending after live migration for legacy guest")] On Wed, 22 Jan 2025 17:51:07 +0100 Stefano Garzarella wrote: > On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote: > >On 22/01/2025 17:20, Stefano Garzarella wrote: > >>

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Daniel P . Berrangé
On Wed, Jan 22, 2025 at 06:22:06PM +0100, Laurent Vivier wrote: > On 22/01/2025 17:51, Stefano Garzarella wrote: > > On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote: > > > On 22/01/2025 17:20, Stefano Garzarella wrote: > > > > On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsir

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Laurent Vivier
On 22/01/2025 17:51, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote: On 22/01/2025 17:20, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote:

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Stefano Garzarella
On Wed, Jan 22, 2025 at 05:41:15PM +0100, Laurent Vivier wrote: On 22/01/2025 17:20, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laure

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Laurent Vivier
On 22/01/2025 17:20, Stefano Garzarella wrote: On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: > In vhost_user_receive() if vhost_net_notify_mi

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Stefano Garzarella
On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: > In vhost_user_receive() if vhost_net_notify_migration_done() reports > an error we display on

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Michael S. Tsirkin
On Wed, Jan 22, 2025 at 05:20:06PM +0100, Stefano Garzarella wrote: > On Wed, Jan 22, 2025 at 08:59:22AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: > > > On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: > > > > In vhost_us

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Michael S. Tsirkin
On Wed, Jan 22, 2025 at 02:42:14PM +0100, Stefano Garzarella wrote: > On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: > > In vhost_user_receive() if vhost_net_notify_migration_done() reports > > an error we display on the console: > > > > Vhost user backend fails to broadcast fake

Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-22 Thread Stefano Garzarella
On Tue, Jan 21, 2025 at 11:00:29AM +0100, Laurent Vivier wrote: In vhost_user_receive() if vhost_net_notify_migration_done() reports an error we display on the console: Vhost user backend fails to broadcast fake RARP This message can be useful if there is a problem to execute VHOST_USER_SEND_R

[PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error

2025-01-21 Thread Laurent Vivier
In vhost_user_receive() if vhost_net_notify_migration_done() reports an error we display on the console: Vhost user backend fails to broadcast fake RARP This message can be useful if there is a problem to execute VHOST_USER_SEND_RARP but it is useless if the backend doesn't support VHOST_USER_P