Re: [PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-23 Thread Dylan Reid
>Agreed - VHOST_USER_PROTCOL_F_CONFIGURE_MEM_SLOTS is negotiated at the >vhost-user, not virtio layer. The dev->protocol_features flags are taken >from the VHOST_USER_GET_PROTOCOL_FEATURES message, which retrieves the >supported vhost-user features from the backend. See libvhost-user for a >simple

Re: [PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-22 Thread Raphael Norwitz
I don't think this is right. On Tue, Dec 22, 2020 at 03:41:26PM -0800, Dylan Reid wrote: > > The `CONFIGURE_MEM_SLOTS` feature is specified by vhost, not by virtio. > Check the vhost flags for it being set. > Agreed - VHOST_USER_PROTCOL_F_CONFIGURE_MEM_SLOTS is negotiated at the vhost-user, not

[PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-22 Thread Dylan Reid
The `CONFIGURE_MEM_SLOTS` feature is specified by vhost, not by virtio. Check the vhost flags for it being set. I noticed this while testing a new vhost implementation that doesn't yet support configuring memory slots and retested with dpdk's block example as well. Signed-off-by: Dylan Reid ---