Re: [PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-22 Thread Michael S. Tsirkin
On Wed, Jun 07, 2023 at 12:32:31PM +0300, Michael Tokarev wrote: > 02.06.2023 19:27, Laurent Vivier wrote: > > in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) > > fails, we call vhost_dev_disable_notifiers() that executes > > virtio_bus_set_host_notifier(false) on all queues,

Re: [PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-07 Thread Michael Tokarev
02.06.2023 19:27, Laurent Vivier wrote: in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) fails, we call vhost_dev_disable_notifiers() that executes virtio_bus_set_host_notifier(false) on all queues, even on queues that have failed to be initialized. This triggers a core dum

Re: [PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-02 Thread Philippe Mathieu-Daudé
On 2/6/23 18:27, Laurent Vivier wrote: in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) fails, we call vhost_dev_disable_notifiers() that executes virtio_bus_set_host_notifier(false) on all queues, even on queues that have failed to be initialized. This triggers a core dump

[PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-02 Thread Laurent Vivier
in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) fails, we call vhost_dev_disable_notifiers() that executes virtio_bus_set_host_notifier(false) on all queues, even on queues that have failed to be initialized. This triggers a core dump in memory_region_del_eventfd(): virtio