Re: [PATCH] vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits

2024-08-05 Thread Jason Wang
On Fri, Aug 2, 2024 at 1:38 PM Akihiko Odaki wrote: > > VIRTIO_NET_F_RSC_EXT is implemented in the rx data path, which vhost > implements, so vhost needs to support the feature if it is ever to be > enabled with vhost. The feature must be disabled otherwise. > > Fixes: 2974e916df87 ("virtio-net: s

Re: [PATCH] vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits

2024-08-02 Thread Michael S. Tsirkin
On Fri, Aug 02, 2024 at 10:34:37AM +0300, Yuri Benditovich wrote: > At the moment kernel (vhost) and vhost user backends do not support > this feature (and IMO they do not need to) > In order to support it they need to implement a) coalescing of > segmented TCP packets and b) population of respecti

Re: [PATCH] vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits

2024-08-02 Thread Yuri Benditovich
At the moment kernel (vhost) and vhost user backends do not support this feature (and IMO they do not need to) In order to support it they need to implement a) coalescing of segmented TCP packets and b) population of respective fields in host-to-guest packets (number of coalesced segments and count

[PATCH] vhost: Add VIRTIO_NET_F_RSC_EXT to vhost feature bits

2024-08-01 Thread Akihiko Odaki
VIRTIO_NET_F_RSC_EXT is implemented in the rx data path, which vhost implements, so vhost needs to support the feature if it is ever to be enabled with vhost. The feature must be disabled otherwise. Fixes: 2974e916df87 ("virtio-net: support RSC v4/v6 tcp traffic for Windows HCK") Reported-by: Jas