Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device

2021-08-23 Thread Markus Armbruster
Thomas Huth writes: > On 14/08/2021 01.36, Jose R. Ziviani wrote: >> If users try to add an isa-vga device that was already registered, >> still in command line, qemu will crash: >> $ qemu-system-mips64el -M pica61 -device isa-vga >> RAMBlock "vga.vram" already registered, abort! >> Aborted (core

Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device

2021-08-16 Thread Jose Ricardo Ziviani
Hello Thomas and Gerd, Thank you for reviewing it. Sending a v2 soon. Thank you very much! On 16/08/2021 02:05, Gerd Hoffmann wrote: Hi, +if (qemu_ram_block_by_name("vga.vram")) { +error_report("vga.vram is already registered, ignoring this device"); +return; +} I

Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device

2021-08-15 Thread Gerd Hoffmann
Hi, > > +if (qemu_ram_block_by_name("vga.vram")) { > > +error_report("vga.vram is already registered, ignoring this > > device"); > > +return; > > +} > > I think we should not ignore the error, but rather turn this into a proper > error (instead of aborting). Yes. Sil

Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device

2021-08-13 Thread Thomas Huth
On 14/08/2021 01.36, Jose R. Ziviani wrote: If users try to add an isa-vga device that was already registered, still in command line, qemu will crash: $ qemu-system-mips64el -M pica61 -device isa-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) That particular board regi

[PATCH] vga: don't abort when adding a duplicate isa-vga device

2021-08-13 Thread Jose R. Ziviani
If users try to add an isa-vga device that was already registered, still in command line, qemu will crash: $ qemu-system-mips64el -M pica61 -device isa-vga RAMBlock "vga.vram" already registered, abort! Aborted (core dumped) That particular board registers such device automaticaly, so it's not ob