Re: [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device

2023-10-11 Thread Cédric Le Goater
On 10/11/23 15:02, Philippe Mathieu-Daudé wrote: Hi, On 22/9/23 04:52, Zhenzhong Duan wrote: vfio_put_device() is a VFIO PCI specific function, rename it with 'vfio_pci' prefix to avoid confusing. Why not, but what about the other functions? yes. Let's tackle that after the IOMMUFD earthqua

Re: [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device

2023-10-11 Thread Philippe Mathieu-Daudé
Hi, On 22/9/23 04:52, Zhenzhong Duan wrote: vfio_put_device() is a VFIO PCI specific function, rename it with 'vfio_pci' prefix to avoid confusing. Why not, but what about the other functions? $ git grep -F '(VFIOPCIDevice *' hw/vfio/pci.c | grep -vF ' vfio_pci_' hw/vfio/pci.c:51:static void

Re: [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device

2023-09-22 Thread Cédric Le Goater
On 9/22/23 04:52, Zhenzhong Duan wrote: vfio_put_device() is a VFIO PCI specific function, rename it with 'vfio_pci' prefix to avoid confusing. No functional change. There is more to be done but it can wait after the big code reshuffle. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhon

[PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device

2023-09-21 Thread Zhenzhong Duan
vfio_put_device() is a VFIO PCI specific function, rename it with 'vfio_pci' prefix to avoid confusing. No functional change. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/h