Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-07-12 Thread Hawkins Jiawei
在 2023/7/12 18:45, Michael Tokarev 写道: > 11.07.2023 04:48, Hawkins Jiawei wrote: > .. >> Sorry for not mentioning that I have moved the patch to the patch series >> titled "Vhost-vdpa Shadow Virtqueue _F_CTRL_RX commands support" at [1]. >> The reason for this move is that the bug in question shoul

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-07-12 Thread Michael Tokarev
11.07.2023 04:48, Hawkins Jiawei wrote: .. Sorry for not mentioning that I have moved the patch to the patch series titled "Vhost-vdpa Shadow Virtqueue _F_CTRL_RX commands support" at [1]. The reason for this move is that the bug in question should not be triggered until the VIRTIO_NET_CTRL_MAC_T

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-07-10 Thread Hawkins Jiawei
On 2023/7/11 2:52, Michael S. Tsirkin wrote: > On Mon, Jun 26, 2023 at 04:26:04PM +0800, Hawkins Jiawei wrote: >> It appears that my commit message and comments did not take this into >> account. I will refactor them in the v2 patch.. > > does not look like you ever sent v2. > Sorry for not mentio

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-07-10 Thread Michael S. Tsirkin
On Mon, Jun 26, 2023 at 04:26:04PM +0800, Hawkins Jiawei wrote: > It appears that my commit message and comments did not take this into > account. I will refactor them in the v2 patch.. does not look like you ever sent v2.

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-06-27 Thread Hawkins Jiawei
On 2023/6/26 17:08, Eugenio Perez Martin wrote: > On Mon, Jun 26, 2023 at 10:26 AM Hawkins Jiawei wrote: >> >> On 2023/6/25 18:48, Eugenio Perez Martin wrote: >>> On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: According to the VirtIO standard, "Since there are no guarantees,

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-06-26 Thread Eugenio Perez Martin
On Mon, Jun 26, 2023 at 10:26 AM Hawkins Jiawei wrote: > > On 2023/6/25 18:48, Eugenio Perez Martin wrote: > > On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: > >> > >> According to the VirtIO standard, "Since there are no guarantees, > >> it can use a hash filter or silently switch to > >>

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-06-26 Thread Hawkins Jiawei
On 2023/6/25 18:48, Eugenio Perez Martin wrote: > On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: >> >> According to the VirtIO standard, "Since there are no guarantees, >> it can use a hash filter or silently switch to >> allmulti or promiscuous mode if it is given too many addresses." >> T

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

2023-06-25 Thread Eugenio Perez Martin
On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: > > According to the VirtIO standard, "Since there are no guarantees, > it can use a hash filter or silently switch to > allmulti or promiscuous mode if it is given too many addresses." > To achive this, QEMU ignores MAC addresses and marks `ma

[PATCH] vdpa: Increase out buffer size for CVQ commands

2023-06-21 Thread Hawkins Jiawei
According to the VirtIO standard, "Since there are no guarantees, it can use a hash filter or silently switch to allmulti or promiscuous mode if it is given too many addresses." To achive this, QEMU ignores MAC addresses and marks `mac_table.x_overflow` in the device internal state in virtio_net_ha