Thank you everyone for the review I have shared
[PATCH v2] utils/log: add qemu_log_timestamp()
in a separate mail thread with the suggested changes.
On Tue, 10 Jun 2025 at 12:37 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 9, 2025 at 2:21 PM Tanish Desai
> wrote:
> >
> > Moved the logic for timesta
On Mon, Jun 9, 2025 at 2:21 PM Tanish Desai wrote:
>
> Moved the logic for timestamped logging (~6 lines) from
> a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in
> util/log.c. This avoids code duplication across binaries and enables reuse as
> a standalone utility.
> Enc
On Mon, 9 Jun 2025, BALATON Zoltan wrote:
On Mon, 9 Jun 2025, Tanish Desai wrote:
Moved the logic for timestamped logging (~6 lines) from
a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in
util/log.c. This avoids code duplication across binaries and enables reuse
as a sta
On Mon, 9 Jun 2025, Tanish Desai wrote:
Moved the logic for timestamped logging (~6 lines) from
a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in
util/log.c. This avoids code duplication across binaries and enables reuse as a
standalone utility.
Encapsulation helps reduc
Two files are attached to show the folder-wise size (in bytes) before and
after the change. Each file lists the folder names along with their
corresponding sizes.
On Mon, Jun 9, 2025 at 11:51 PM Tanish Desai
wrote:
> Moved the logic for timestamped logging (~6 lines) from
> a_nocheck__trace_foo(
Moved the logic for timestamped logging (~6 lines) from
a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in
util/log.c. This avoids code duplication across binaries and enables reuse as a
standalone utility.
Encapsulation helps reduce build size significantly, particularly w