Re: [PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-12 Thread Tanish Desai
Thank you everyone for the review I have shared [PATCH v2] utils/log: add qemu_log_timestamp() in a separate mail thread with the suggested changes. On Tue, 10 Jun 2025 at 12:37 AM, Stefan Hajnoczi wrote: > On Mon, Jun 9, 2025 at 2:21 PM Tanish Desai > wrote: > > > > Moved the logic for timesta

Re: [PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-09 Thread Stefan Hajnoczi
On Mon, Jun 9, 2025 at 2:21 PM Tanish Desai wrote: > > Moved the logic for timestamped logging (~6 lines) from > a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in > util/log.c. This avoids code duplication across binaries and enables reuse as > a standalone utility. > Enc

Re: [PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-09 Thread BALATON Zoltan
On Mon, 9 Jun 2025, BALATON Zoltan wrote: On Mon, 9 Jun 2025, Tanish Desai wrote: Moved the logic for timestamped logging (~6 lines) from a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in util/log.c. This avoids code duplication across binaries and enables reuse as a sta

Re: [PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-09 Thread BALATON Zoltan
On Mon, 9 Jun 2025, Tanish Desai wrote: Moved the logic for timestamped logging (~6 lines) from a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in util/log.c. This avoids code duplication across binaries and enables reuse as a standalone utility. Encapsulation helps reduc

Re: [PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-09 Thread Tanish Desai
Two files are attached to show the folder-wise size (in bytes) before and after the change. Each file lists the folder names along with their corresponding sizes. On Mon, Jun 9, 2025 at 11:51 PM Tanish Desai wrote: > Moved the logic for timestamped logging (~6 lines) from > a_nocheck__trace_foo(

[PATCH] utils/log: add qemu_log_timestamp() to encapsulate timestamp logging

2025-06-09 Thread Tanish Desai
Moved the logic for timestamped logging (~6 lines) from a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in util/log.c. This avoids code duplication across binaries and enables reuse as a standalone utility. Encapsulation helps reduce build size significantly, particularly w