Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
Hi Daniel, > > > > The experienced logfile entry is: > > > > > > > > qemu-system-x86_64: -device > > > > virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90ea: > > > > Could not open '/dev/drbd1003': Interrupted system cal

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 04:24:45PM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2024 at 16:21, Daniel P. Berrangé wrote: > > > > On Wed, Jul 31, 2024 at 03:32:52PM +0100, Peter Maydell wrote: > > > This is why we have the RETRY_ON_EINTR() macro, right? > > > > > > Currently we have some places tha

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 16:21, Daniel P. Berrangé wrote: > > On Wed, Jul 31, 2024 at 03:32:52PM +0100, Peter Maydell wrote: > > This is why we have the RETRY_ON_EINTR() macro, right? > > > > Currently we have some places that call qemu_open_old() inside > > RETRY_ON_EINTR -- we should decide whethe

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 03:32:52PM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2024 at 15:11, Daniel P. Berrangé wrote: > > > > On Wed, Jul 31, 2024 at 03:25:24PM +0200, Philipp Reisner wrote: > > > As with many syscalls, open() might be interrupted by a signal. > > > > > > The experienced logfil

[PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
As with many syscalls, open() might be interrupted by a signal. The experienced logfile entry is: qemu-system-x86_64: -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90ea: Could not open '/dev/drbd1003': Interrup

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 15:11, Daniel P. Berrangé wrote: > > On Wed, Jul 31, 2024 at 03:25:24PM +0200, Philipp Reisner wrote: > > As with many syscalls, open() might be interrupted by a signal. > > > > The experienced logfile entry is: > > > > qemu-system-x86_64: -device > > virtio-blk-pci,bus=pci

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 03:25:24PM +0200, Philipp Reisner wrote: > As with many syscalls, open() might be interrupted by a signal. > > The experienced logfile entry is: > > qemu-system-x86_64: -device > virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-ca

Re: [PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread David Hildenbrand
On 31.07.24 15:25, Philipp Reisner wrote: As with many syscalls, open() might be interrupted by a signal. The experienced logfile entry is: qemu-system-x86_64: -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90e

[PATCH] util: retry open() when it gets interrupted by a signal

2024-07-31 Thread Philipp Reisner
As with many syscalls, open() might be interrupted by a signal. The experienced logfile entry is: qemu-system-x86_64: -device virtio-blk-pci,bus=pci.0,addr=0x7,drive=libvirt-2-format,id=virtio-disk0,bootindex=2,write-cache=on,serial=1b990c4d13b74a4e90ea: Could not open '/dev/drbd1003': Interrup