Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-11 Thread Eduardo Habkost
On Wed, Mar 11, 2020 at 12:37:17PM +, Peter Maydell wrote: > On Wed, 11 Mar 2020 at 00:43, Liu, Jingqi wrote: > > 1) If '#include ' first then '#include qemu/osdep.h', it > > should be fine. > > > > 2) Peter mentioned osdep.h should go first. > > > > It will cause redefinitions of other MAP_*

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-11 Thread Peter Maydell
On Wed, 11 Mar 2020 at 00:43, Liu, Jingqi wrote: > 1) If '#include ' first then '#include qemu/osdep.h', it > should be fine. > > 2) Peter mentioned osdep.h should go first. > > It will cause redefinitions of other MAP_* macros after '#include > '. > > This is where the conflict lies. osdep.h fi

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-10 Thread Liu, Jingqi
On 3/10/2020 5:12 PM, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:58:38PM +0800, Liu, Jingqi wrote: On 3/9/2020 9:35 PM, Peter Maydell wrote: On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: On 3/6/2020 12:40 AM, Peter Maydell wrote: On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: On

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 04:58:38PM +0800, Liu, Jingqi wrote: > On 3/9/2020 9:35 PM, Peter Maydell wrote: > > On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: > > > On 3/6/2020 12:40 AM, Peter Maydell wrote: > > > > On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: > > > > > On a Thursday in 2020, Jing

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-10 Thread Liu, Jingqi
On 3/9/2020 9:35 PM, Peter Maydell wrote: On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: On 3/6/2020 12:40 AM, Peter Maydell wrote: On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: > > On 3/6/2020 12:40 AM, Peter Maydell wrote: > > On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: > >> On a Thursday in 2020, Jingqi Liu wrote: > >>> The CONFIG_LINUX symbol is always not defined in this file. > >>> This fixes that "config-host.h" he

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-09 Thread Liu, Jingqi
On 3/6/2020 12:40 AM, Peter Maydell wrote: On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes that "config-host.h" header file is not included for getting macros. Signed-off-by: Jingqi L

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-05 Thread Liu, Jingqi
On 3/6/2020 12:40 AM, Peter Maydell wrote: On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes that "config-host.h" header file is not included for getting macros. Signed-off-by: Jingqi L

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-05 Thread Liu, Jingqi
On 3/6/2020 12:10 AM, Ján Tomko wrote: On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes that "config-host.h" header file is not included for getting macros. Signed-off-by: Jingqi Liu --- util/mmap-alloc.c | 2 ++ 1 file changed, 2 i

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-05 Thread Peter Maydell
On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: > > On a Thursday in 2020, Jingqi Liu wrote: > >The CONFIG_LINUX symbol is always not defined in this file. > >This fixes that "config-host.h" header file is not included > >for getting macros. > > > >Signed-off-by: Jingqi Liu > >--- > > util/mmap-all

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-05 Thread Ján Tomko
On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes that "config-host.h" header file is not included for getting macros. Signed-off-by: Jingqi Liu --- util/mmap-alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/mmap-all

[PATCH] util: fix to get configuration macros in util/mmap-alloc.c

2020-03-05 Thread Jingqi Liu
The CONFIG_LINUX symbol is always not defined in this file. This fixes that "config-host.h" header file is not included for getting macros. Signed-off-by: Jingqi Liu --- util/mmap-alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 27dcccd8ec