Re: [PATCH] util/hexdump: Convert to take a void pointer argument

2020-08-22 Thread Philippe Mathieu-Daudé
On 8/22/20 6:18 PM, Peter Maydell wrote: > On Sat, 22 Aug 2020 at 16:05, Philippe Mathieu-Daudé wrote: >> Most uses of qemu_hexdump() do not take an array of char >> as input, forcing use of cast. Since we can use this >> helper to dump any kind of buffer, use a pointer to void >> argument inst

Re: [PATCH] util/hexdump: Convert to take a void pointer argument

2020-08-22 Thread Peter Maydell
On Sat, 22 Aug 2020 at 16:05, Philippe Mathieu-Daudé wrote: > Most uses of qemu_hexdump() do not take an array of char > as input, forcing use of cast. Since we can use this > helper to dump any kind of buffer, use a pointer to void > argument instead. > > Signed-off-by: Philippe Mathieu-Daudé >

[PATCH] util/hexdump: Convert to take a void pointer argument

2020-08-22 Thread Philippe Mathieu-Daudé
Most uses of qemu_hexdump() do not take an array of char as input, forcing use of cast. Since we can use this helper to dump any kind of buffer, use a pointer to void argument instead. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu-common.h| 2 +- hw/dma/xlnx_dpdma.c | 2 +- h