Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2020-01-20 Thread Carlos Santos
On Thu, Jan 16, 2020 at 9:04 PM Richard Henderson wrote: > > On 12/16/19 1:18 AM, Carlos Santos wrote: > > On Thu, Oct 17, 2019 at 8:06 PM Carlos Santos wrote: > >> > >> On Thu, Oct 17, 2019 at 9:47 AM Peter Maydell > >> wrote: > >>> > >>> On Thu, 17 Oct 2019 at 13:39, wrote: > > Fro

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2020-01-16 Thread Richard Henderson
On 12/16/19 1:18 AM, Carlos Santos wrote: > On Thu, Oct 17, 2019 at 8:06 PM Carlos Santos wrote: >> >> On Thu, Oct 17, 2019 at 9:47 AM Peter Maydell >> wrote: >>> >>> On Thu, 17 Oct 2019 at 13:39, wrote: From: Carlos Santos uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-12-16 Thread Carlos Santos
On Thu, Oct 17, 2019 at 8:06 PM Carlos Santos wrote: > > On Thu, Oct 17, 2019 at 9:47 AM Peter Maydell > wrote: > > > > On Thu, 17 Oct 2019 at 13:39, wrote: > > > > > > From: Carlos Santos > > > > > > uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE > > > but the corres

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-10-17 Thread Carlos Santos
On Thu, Oct 17, 2019 at 9:47 AM Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 13:39, wrote: > > > > From: Carlos Santos > > > > uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE > > but the corresponding sysconf calls returns -1, which is a valid result, > > meaning that

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 13:39, wrote: > > From: Carlos Santos > > uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE > but the corresponding sysconf calls returns -1, which is a valid result, > meaning that the limit is indeterminate. > > Handle this situation using the fallb

[PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-10-17 Thread casantos
From: Carlos Santos uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE but the corresponding sysconf calls returns -1, which is a valid result, meaning that the limit is indeterminate. Handle this situation using the fallback values instead of crashing due to an assertion f