Re: [PATCH] usb-ccid: make ids and descriptor configurable

2023-01-23 Thread Ripke, Klaus
Hi Philippe, so I guess it's rejected. Any suggestions? TIA Klaus On Tue, 2023-01-17 at 08:04 +0100, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 16/1/23 16:46, Ripke, Klaus wrote: > > Signed-off-by: Klaus Ripke > > > > hw/usb/dev-smartcard-reader.c: > > Set some static values from ccid_p

Re: [PATCH] usb-ccid: make ids and descriptor configurable

2023-01-17 Thread Ripke, Klaus
hi Philippe, On Tue, 2023-01-17 at 08:04 +0100, Philippe Mathieu-Daudé wrote: > If you create 2 devices with different properties, the > first gets its properties overwritten with the second's > ones. The !initialized guard should prevent that. In practize you would not create more usb-ccid device

Re: [PATCH] usb-ccid: make ids and descriptor configurable

2023-01-16 Thread Philippe Mathieu-Daudé
Hi Klaus, On 16/1/23 16:46, Ripke, Klaus wrote: Signed-off-by: Klaus Ripke hw/usb/dev-smartcard-reader.c: Set some static values from ccid_properties. ---  hw/usb/dev-smartcard-reader.c | 35 ++-  1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/

[PATCH] usb-ccid: make ids and descriptor configurable

2023-01-16 Thread Ripke, Klaus
Signed-off-by: Klaus Ripke hw/usb/dev-smartcard-reader.c: Set some static values from ccid_properties. ---  hw/usb/dev-smartcard-reader.c | 35 ++-  1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-

Re: [PATCH] usb-ccid: make ids and descriptor configurable

2023-01-11 Thread Marc-André Lureau
Hi Klaus On Tue, Jan 10, 2023 at 7:49 PM Ripke, Klaus wrote: > > Signed-off-by: Klaus Ripke > > hw/usb/dev-smartcard-reader.c: > Set static values from env vars QEMU_CCID_VENDOR/PRODUCT_ID and > _DESCRIPTOR We don't use environment variables to configure devices. Please add properties to ccid_p

[PATCH] usb-ccid: make ids and descriptor configurable

2023-01-10 Thread Ripke, Klaus
Signed-off-by: Klaus Ripke hw/usb/dev-smartcard-reader.c: Set static values from env vars QEMU_CCID_VENDOR/PRODUCT_ID and _DESCRIPTOR ---  hw/usb/dev-smartcard-reader.c | 27 ---  1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c