Re: [PATCH] ui/vnc-clipboard: fix adding notifier twice

2021-11-22 Thread Vladimir Sementsov-Ogievskiy
21.11.2021 22:12, Nikta Lapshin wrote: On 11/10/21 13:38, Vladimir Sementsov-Ogievskiy wrote: vnc_server_cut_text_caps() is not guaranteed to be called only once. If it called twice, we finally call notifier_list_add() twice with same element. Which leads to loopback QLIST. So, on next notifie

Re: [PATCH] ui/vnc-clipboard: fix adding notifier twice

2021-11-21 Thread Nikta Lapshin
On 11/10/21 13:38, Vladimir Sementsov-Ogievskiy wrote: vnc_server_cut_text_caps() is not guaranteed to be called only once. If it called twice, we finally call notifier_list_add() twice with same element. Which leads to loopback QLIST. So, on next notifier_list_notify() we'll loop forever and

[PATCH] ui/vnc-clipboard: fix adding notifier twice

2021-11-10 Thread Vladimir Sementsov-Ogievskiy
vnc_server_cut_text_caps() is not guaranteed to be called only once. If it called twice, we finally call notifier_list_add() twice with same element. Which leads to loopback QLIST. So, on next notifier_list_notify() we'll loop forever and QEMU stuck. So, let's only register new notifier if it's n