Re: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread Changbin Du
On Mon, Apr 27, 2020 at 02:11:59PM +0100, Peter Maydell wrote: > On Mon, 27 Apr 2020 at 13:19, Changbin Du wrote: > > > > I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via > > ssh forwarding even the window has been crated already. I am not sure > > whether this is a bug of

Re: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread Peter Maydell
On Mon, 27 Apr 2020 at 13:19, Changbin Du wrote: > > I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via > ssh forwarding even the window has been crated already. I am not sure > whether this is a bug of SDL, but we'd better check it carefully. > > Signed-off-by: Changbin Du

Re: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427121823.8094-1-changbin...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427121823.8094-1-changbin...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference Message-id: 20200427121823.8094-1

Re: [PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200427121823.8094-1-changbin...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ex

[PATCH] ui/sdl2: fix segment fault caused by null pointer dereference

2020-04-27 Thread Changbin Du
I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via ssh forwarding even the window has been crated already. I am not sure whether this is a bug of SDL, but we'd better check it carefully. Signed-off-by: Changbin Du --- ui/sdl2.c | 9 + 1 file changed, 9 insertions(+