Re: [PATCH] ui/keymaps: Avoid trace crash and improve error messages

2025-07-23 Thread Philippe Mathieu-Daudé
On 23/7/25 15:15, Markus Armbruster wrote: parse_keyboard_layout() passes a possibly null @filename to trace_keymap_parse(). Trace backend log then formats it with %s, which crashes on some systems. Fix by moving the null check before the trace_keymap_parse(). While there, improve the error me

Re: [PATCH] ui/keymaps: Avoid trace crash and improve error messages

2025-07-23 Thread Marc-André Lureau
On Wed, Jul 23, 2025 at 5:15 PM Markus Armbruster wrote: > parse_keyboard_layout() passes a possibly null @filename to > trace_keymap_parse(). Trace backend log then formats it with %s, > which crashes on some systems. > > Fix by moving the null check before the trace_keymap_parse(). > > While t

[PATCH] ui/keymaps: Avoid trace crash and improve error messages

2025-07-23 Thread Markus Armbruster
parse_keyboard_layout() passes a possibly null @filename to trace_keymap_parse(). Trace backend log then formats it with %s, which crashes on some systems. Fix by moving the null check before the trace_keymap_parse(). While there, improve the error messages a bit. Fixes: d3b787fa7dde (keymaps: