Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-19 Thread Gerd Hoffmann
> > I think there are people using QEMU to run old MacOS versions on MacOS > > X/macOS and may not follow this mailing list but I'm sure they'll complain > > once you break it. > > It was not clear what "full screen APIs" refer to in my patch. Today > macOS have three different methods to enter fu

Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-19 Thread Akihiko Odaki
2021年2月19日(金) 19:24 BALATON Zoltan : > > On Fri, 19 Feb 2021, Akihiko Odaki wrote: > > 2021年2月17日(水) 22:09 Gerd Hoffmann : > >> > >> On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: > >>> The detections of full screen APIs were wrong. A detection is coded as: > >>> [NSView respondsToS

Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-19 Thread BALATON Zoltan
On Fri, 19 Feb 2021, Akihiko Odaki wrote: 2021年2月17日(水) 22:09 Gerd Hoffmann : On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: The detections of full screen APIs were wrong. A detection is coded as: [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] but it shou

Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-19 Thread Akihiko Odaki
2021年2月17日(水) 22:09 Gerd Hoffmann : > > On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: > > The detections of full screen APIs were wrong. A detection is coded as: > > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] > > but it should be: > > [NSView > > instanc

Re: [PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote: > The detections of full screen APIs were wrong. A detection is coded as: > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] > but it should be: > [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithO

[PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-11 Thread Akihiko Odaki
The detections of full screen APIs were wrong. A detection is coded as: [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] but it should be: [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)] The uses of full screen APIs were also incorrect, and if you