Re: [PATCH] trace/simple: Fix unauthorized enable

2020-05-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, May 15, 2020 at 09:00:21AM +0200, Markus Armbruster wrote: >> diff --git a/trace/simple.c b/trace/simple.c >> index fc7106ec49..906391538f 100644 >> --- a/trace/simple.c >> +++ b/trace/simple.c >> @@ -302,10 +302,10 @@ static int st_write_event_mapping(void) >>

Re: [PATCH] trace/simple: Fix unauthorized enable

2020-05-15 Thread Stefan Hajnoczi
On Fri, May 15, 2020 at 09:00:21AM +0200, Markus Armbruster wrote: > diff --git a/trace/simple.c b/trace/simple.c > index fc7106ec49..906391538f 100644 > --- a/trace/simple.c > +++ b/trace/simple.c > @@ -302,10 +302,10 @@ static int st_write_event_mapping(void) > return 0; > } > > -void st_

[PATCH] trace/simple: Fix unauthorized enable

2020-05-15 Thread Markus Armbruster
st_set_trace_file() accidentally enables tracing. It's called unconditionally during startup, which is why QEMU built with the simple trace backend always writes a trace file "trace-$PID". This has been broken for quite a while. I didn't track down the exact commit. Fix st_set_trace_file() to r