Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-30 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Apr 30, 2020 at 07:23:59AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> > +check-flake8: >> > + $(call quiet-command,flake8 --ignore=$(FLAKE8_IGNORE) $(PYTHON_FILES)) >> > +else >> > +check-flake8: >> > +endif >> > + >> > +check: check-bl

Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-30 Thread Paolo Bonzini
On 29/04/20 17:36, Daniel P. Berrangé wrote: > The flake8 program is a standard tool used by Python projects for > validating many commonly recommended style rules. It would be desirable > for QEMU to come into alignment with normal Python coding style best > practices. > > QEMU currently violates

Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-30 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 12:29:28PM +0200, Paolo Bonzini wrote: > On 29/04/20 17:36, Daniel P. Berrangé wrote: > > The flake8 program is a standard tool used by Python projects for > > validating many commonly recommended style rules. It would be desirable > > for QEMU to come into alignment with no

Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-30 Thread Daniel P . Berrangé
On Thu, Apr 30, 2020 at 07:23:59AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > +check-flake8: > > + $(call quiet-command,flake8 --ignore=$(FLAKE8_IGNORE) $(PYTHON_FILES)) > > +else > > +check-flake8: > > +endif > > + > > +check: check-block check-qapi-schema check-unit check

Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-29 Thread Markus Armbruster
Daniel P. Berrangé writes: > The flake8 program is a standard tool used by Python projects for > validating many commonly recommended style rules. It would be desirable > for QEMU to come into alignment with normal Python coding style best > practices. > > QEMU currently violates a huge number of

Re: [PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-29 Thread John Snow
On 4/29/20 11:36 AM, Daniel P. Berrangé wrote: > The flake8 program is a standard tool used by Python projects for > validating many commonly recommended style rules. It would be desirable > for QEMU to come into alignment with normal Python coding style best > practices. > > QEMU currently vio

[PATCH] tests: add a "check-flake8" test for validating python code style

2020-04-29 Thread Daniel P . Berrangé
The flake8 program is a standard tool used by Python projects for validating many commonly recommended style rules. It would be desirable for QEMU to come into alignment with normal Python coding style best practices. QEMU currently violates a huge number of the style rules, so we can't blindly tu