Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-09 Thread Peter Maydell
On Wed, 9 Jun 2021 at 13:36, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 8 Jun 2021 at 20:51, Marc-André Lureau > > wrote: > >> > >> Hi > >> > >> On Tue, Jun 8, 2021 at 9:06 PM Peter Maydell > >> wrote: > >>> I think that improving the quality of the failure reporting > >>

Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-09 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 8 Jun 2021 at 20:51, Marc-André Lureau > wrote: >> >> Hi >> >> On Tue, Jun 8, 2021 at 9:06 PM Peter Maydell >> wrote: >>> I think that improving the quality of the failure reporting >>> in 'make check' is useful, and that we should probably turn >>> on g_test_se

Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-08 Thread Daniel P . Berrangé
On Tue, Jun 08, 2021 at 11:51:35PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jun 8, 2021 at 9:06 PM Peter Maydell > wrote: > > > Coverity spots some minor error-handling issues in this test code. > > These are mostly due to the test code assuming that the glib test > > macros g_assert_cmp

Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-08 Thread Daniel P . Berrangé
On Tue, Jun 08, 2021 at 06:06:06PM +0100, Peter Maydell wrote: > Coverity spots some minor error-handling issues in this test code. > These are mostly due to the test code assuming that the glib test > macros g_assert_cmpint() and friends will always abort on failure. > This is not the case: if the

Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-08 Thread Peter Maydell
On Tue, 8 Jun 2021 at 20:51, Marc-André Lureau wrote: > > Hi > > On Tue, Jun 8, 2021 at 9:06 PM Peter Maydell wrote: >> I think that improving the quality of the failure reporting >> in 'make check' is useful, and that we should probably turn >> on g_test_set_nonfatal_assertions() everywhere. (Th

Re: [PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-08 Thread Marc-André Lureau
Hi On Tue, Jun 8, 2021 at 9:06 PM Peter Maydell wrote: > Coverity spots some minor error-handling issues in this test code. > These are mostly due to the test code assuming that the glib test > macros g_assert_cmpint() and friends will always abort on failure. > This is not the case: if the test

[PATCH] tests/unit/test-char.c: Fix error handling issues

2021-06-08 Thread Peter Maydell
Coverity spots some minor error-handling issues in this test code. These are mostly due to the test code assuming that the glib test macros g_assert_cmpint() and friends will always abort on failure. This is not the case: if the test case chooses to call g_test_set_nonfatal_assertions() then they w