Re: [PATCH] tests/qtest: misc tweaks to readconfig

2022-08-11 Thread Philippe Mathieu-Daudé via
On 9/8/22 11:38, Daniel P. Berrangé wrote: The property name parameter is ignored when visiting a top level type, but the obvious typo should be fixed to avoid confusion. A few indentation issues were tidied up. We can break out of the loop when finding the RNG device. Finally, close the temp FD

Re: [PATCH] tests/qtest: misc tweaks to readconfig

2022-08-11 Thread Thomas Huth
On 09/08/2022 11.38, Daniel P. Berrangé wrote: The property name parameter is ignored when visiting a top level type, but the obvious typo should be fixed to avoid confusion. A few indentation issues were tidied up. We can break out of the loop when finding the RNG device. Finally, close the temp

Re: [PATCH] tests/qtest: misc tweaks to readconfig

2022-08-09 Thread Marc-André Lureau
On Tue, Aug 9, 2022 at 1:39 PM Daniel P. Berrangé wrote: > The property name parameter is ignored when visiting a top > level type, but the obvious typo should be fixed to avoid > confusion. A few indentation issues were tidied up. We > can break out of the loop when finding the RNG device. > Fin

[PATCH] tests/qtest: misc tweaks to readconfig

2022-08-09 Thread Daniel P . Berrangé
The property name parameter is ignored when visiting a top level type, but the obvious typo should be fixed to avoid confusion. A few indentation issues were tidied up. We can break out of the loop when finding the RNG device. Finally, close the temp FD immediately when no longer needed. Signed-of