Re: [PATCH] tests/qtest: Add test for ASPEED SCU

2025-06-30 Thread Cédric Le Goater
I'll remove the `scu-utils` in v2. Q: Are you more concerned about the helper methods or the separate `scu-utils` file? The files. If the helper functions are fine, should they be marked as `static inline`? The helpers are fine to keep. Thanks, C.

Re: [PATCH] tests/qtest: Add test for ASPEED SCU

2025-06-29 Thread Tan Siewert
Hi Jamin, On 30.06.25 08:37, Cédric Le Goater wrote: Hello Tan, On 6/29/25 15:54, Tan Siewert wrote: This adds basic tests for the ASPEED System Control Unit (SCU) and its protection mechanism on the AST2500 and AST2600 platforms. The tests verify:    - That SCU protection registers can be un

Re: [PATCH] tests/qtest: Add test for ASPEED SCU

2025-06-29 Thread Cédric Le Goater
Hello Tan, On 6/29/25 15:54, Tan Siewert wrote: This adds basic tests for the ASPEED System Control Unit (SCU) and its protection mechanism on the AST2500 and AST2600 platforms. The tests verify: - That SCU protection registers can be unlocked and locked again - That modifying the primary

[PATCH] tests/qtest: Add test for ASPEED SCU

2025-06-29 Thread Tan Siewert
This adds basic tests for the ASPEED System Control Unit (SCU) and its protection mechanism on the AST2500 and AST2600 platforms. The tests verify: - That SCU protection registers can be unlocked and locked again - That modifying the primary protection register on AST2600 also affects the