Re: [PATCH] tests/docker: only enable ubsan for test-clang

2019-10-06 Thread John Snow
On 10/6/19 12:06 PM, Paolo Bonzini wrote: > On 01/10/19 19:59, John Snow wrote: >> >> it looked quite like --enable-sanitizers was indeed the same as >> -fsanitize=undefined; or at least was a superset of such. >> >> I suppose the argument you're making here is that we *only* want ubsan >> for t

Re: [PATCH] tests/docker: only enable ubsan for test-clang

2019-10-06 Thread Paolo Bonzini
On 01/10/19 19:59, John Snow wrote: > > it looked quite like --enable-sanitizers was indeed the same as > -fsanitize=undefined; or at least was a superset of such. > > I suppose the argument you're making here is that we *only* want ubsan > for test-clang? > > (I guess so, since test-debug also

Re: [PATCH] tests/docker: only enable ubsan for test-clang

2019-10-01 Thread John Snow
On 10/1/19 10:14 AM, Paolo Bonzini wrote: > -fsanitize=undefined is not the same thing as --enable-sanitizers. After > commit 47c823e ("tests/docker: add sanitizers back to clang build", > 2019-09-11) > test-clang is almost duplicating the asan (test-debug) test, so > partly revert commit 47c8

[PATCH] tests/docker: only enable ubsan for test-clang

2019-10-01 Thread Paolo Bonzini
-fsanitize=undefined is not the same thing as --enable-sanitizers. After commit 47c823e ("tests/docker: add sanitizers back to clang build", 2019-09-11) test-clang is almost duplicating the asan (test-debug) test, so partly revert commit 47c823e5b while leaving ubsan enabled. Signed-off-by: Paolo