Re: [PATCH] tests/avocado: Fix console data loss

2023-09-14 Thread Nicholas Piggin
On Wed Sep 13, 2023 at 6:51 PM AEST, Alex Bennée wrote: > > Nicholas Piggin writes: > > > Occasionally some avocado tests will fail waiting for console line > > despite the machine running correctly. Console data goes missing, as can > > be seen in the console log. This is due to _console_interact

Re: [PATCH] tests/avocado: Fix console data loss

2023-09-14 Thread John Snow
On Wed, Sep 13, 2023 at 4:53 AM Alex Bennée wrote: > > > Nicholas Piggin writes: > > > Occasionally some avocado tests will fail waiting for console line > > despite the machine running correctly. Console data goes missing, as can > > be seen in the console log. This is due to _console_interactio

Re: [PATCH] tests/avocado: Fix console data loss

2023-09-13 Thread Alex Bennée
Nicholas Piggin writes: > Occasionally some avocado tests will fail waiting for console line > despite the machine running correctly. Console data goes missing, as can > be seen in the console log. This is due to _console_interaction calling > makefile() on the console socket each time it is in

Re: [PATCH] tests/avocado: Fix console data loss

2023-09-12 Thread Philippe Mathieu-Daudé
+Alex who also looked at that IIRC. On 12/9/23 15:13, Nicholas Piggin wrote: Occasionally some avocado tests will fail waiting for console line despite the machine running correctly. Console data goes missing, as can be seen in the console log. This is due to _console_interaction calling makefil

Re: [PATCH] tests/avocado: Fix console data loss

2023-09-12 Thread Daniel P . Berrangé
On Tue, Sep 12, 2023 at 11:13:40PM +1000, Nicholas Piggin wrote: > Occasionally some avocado tests will fail waiting for console line > despite the machine running correctly. Console data goes missing, as can > be seen in the console log. This is due to _console_interaction calling > makefile() on

[PATCH] tests/avocado: Fix console data loss

2023-09-12 Thread Nicholas Piggin
Occasionally some avocado tests will fail waiting for console line despite the machine running correctly. Console data goes missing, as can be seen in the console log. This is due to _console_interaction calling makefile() on the console socket each time it is invoked, which must be losing old buff