Re: [PATCH] tcg/s390: Fix compare instruction from extended-immediate facility

2021-02-04 Thread Richard W.M. Jones
On Thu, Feb 04, 2021 at 07:29:02PM +0100, Philippe Mathieu-Daudé wrote: > The code is currently comparing c2 to the type promotion of > uint32_t and int32_t. That is, the conversion rules are as: > > (common_type) c2 == (common_type) (uint32_t) > (is_unsigned >

Re: [PATCH] tcg/s390: Fix compare instruction from extended-immediate facility

2021-02-04 Thread David Hildenbrand
On 04.02.21 19:29, Philippe Mathieu-Daudé wrote: The code is currently comparing c2 to the type promotion of uint32_t and int32_t. That is, the conversion rules are as: (common_type) c2 == (common_type) (uint32_t) (is_unsigned ? (uint32_t)c2

Re: [PATCH] tcg/s390: Fix compare instruction from extended-immediate facility

2021-02-04 Thread Richard Henderson
On 2/4/21 8:29 AM, Philippe Mathieu-Daudé wrote: > The code is currently comparing c2 to the type promotion of > uint32_t and int32_t. That is, the conversion rules are as: > > (common_type) c2 == (common_type) (uint32_t) > (is_unsigned > ? (uint32

[PATCH] tcg/s390: Fix compare instruction from extended-immediate facility

2021-02-04 Thread Philippe Mathieu-Daudé
The code is currently comparing c2 to the type promotion of uint32_t and int32_t. That is, the conversion rules are as: (common_type) c2 == (common_type) (uint32_t) (is_unsigned ? (uint32_t)c2 : (uint32_t)(int32_t)c2) In th