[PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Jordan Niethe
Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduced a race between loading the jmp target i

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Jordan Niethe
On Mon, Jul 17, 2023 at 11:24 AM Jordan Niethe wrote: [snip] > > Reported-by: Anushree Mathur > Co-developed-by: Benjamin Gray > Signed-off-by: Jordan Niethe Sorry, should also have: Signed-off-by: Benjamin Gray [snip]

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Michael Tokarev
17.07.2023 04:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduce

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Cédric Le Goater
On 7/17/23 09:35, Richard Henderson wrote: On 7/17/23 02:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions whe

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Richard Henderson
On 7/17/23 02:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduce

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

2023-07-17 Thread Anushree Mathur
On 7/17/23 06:53, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introdu