Re: [PATCH] tcg/mips: mips sync* encode error

2020-04-12 Thread Philippe Mathieu-Daudé
On 4/11/20 2:46 PM, lixinyu wrote: > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > OPC_SYNC_RMB have wrong encode. According to the mips manual, > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction > er

Re: [PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread Aleksandar Markovic
20:08 Sub, 11.04.2020. Richard Henderson је написао/ла: > > On 4/11/20 5:46 AM, lixinyu wrote: > > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > > OPC_SYNC_RMB have wrong encode. According to the mips manual, > > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > > '

Re: [PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread Richard Henderson
On 4/11/20 5:46 AM, lixinyu wrote: > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > OPC_SYNC_RMB have wrong encode. According to the mips manual, > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction > er

[PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread lixinyu
OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and OPC_SYNC_RMB have wrong encode. According to the mips manual, their encode should be 'OPC_SYNC | 0x?? << 6' rather than 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction errors. These instructions often appear with mu