Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-31 Thread Richard Henderson
On 8/31/22 01:30, Yoshinori Sato wrote: +/* gUSA information field in CPUArchState.flags */ +/* + b16 - b23: Exclusive region range (negative) + b24: pc in exclusive region flag (use normal decode) +*/ +#define GUSA_SHIFT 16 +#define GUSA_EXCLUSIVE (1 << 24) No good. Th

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-31 Thread Richard Henderson
On 8/30/22 18:30, Yoshinori Sato wrote: On Tue, 30 Aug 2022 01:10:29 +0900, Richard Henderson wrote: On 8/29/22 02:05, BALATON Zoltan wrote: On Sun, 28 Aug 2022, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-31 Thread Yoshinori Sato
On Tue, 30 Aug 2022 01:10:29 +0900, Richard Henderson wrote: > > On 8/29/22 02:05, BALATON Zoltan wrote: > > On Sun, 28 Aug 2022, Richard Henderson wrote: > >> The value previously chosen overlaps GUSA_MASK. > >> > >> Cc: qemu-sta...@nongnu.org > >> Fixes: 4da06fb3062 ("target/sh4: Implement prct

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-30 Thread Yoshinori Sato
On Tue, 30 Aug 2022 01:10:29 +0900, Richard Henderson wrote: > > On 8/29/22 02:05, BALATON Zoltan wrote: > > On Sun, 28 Aug 2022, Richard Henderson wrote: > >> The value previously chosen overlaps GUSA_MASK. > >> > >> Cc: qemu-sta...@nongnu.org > >> Fixes: 4da06fb3062 ("target/sh4: Implement prct

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-29 Thread Richard Henderson
On 8/29/22 02:05, BALATON Zoltan wrote: On Sun, 28 Aug 2022, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh4: Implement prctl_unalign_sigbus") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/856 Signed-o

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-29 Thread BALATON Zoltan
On Sun, 28 Aug 2022, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh4: Implement prctl_unalign_sigbus") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/856 Signed-off-by: Richard Henderson --- target/sh4/

Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-28 Thread Richard Henderson
On 8/28/22 19:13, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. ... which meant that we didn't translate the gusa sequence into an atomic operation, which meant the multi-threaded tests fail. Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh4: Implement prc

[PATCH] target/sh4: Fix TB_FLAG_UNALIGN

2022-08-28 Thread Richard Henderson
The value previously chosen overlaps GUSA_MASK. Cc: qemu-sta...@nongnu.org Fixes: 4da06fb3062 ("target/sh4: Implement prctl_unalign_sigbus") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/856 Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1