Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-31 Thread Ilya Leoshkevich
On Mon, 2023-07-31 at 07:55 -0700, Richard Henderson wrote: > On 7/31/23 01:26, Ilya Leoshkevich wrote: > > > > +    case PGM_PROTECTION: > > > > +    case PGM_TRANS_SPEC: > > > > +    assert(env->int_pgm_code == env->tlb_fill_exc); > > > > +    set_trans_exc_code = true; > > > > +    a

Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-31 Thread Richard Henderson
On 7/31/23 01:26, Ilya Leoshkevich wrote: +    case PGM_PROTECTION: +    case PGM_TRANS_SPEC: +    assert(env->int_pgm_code == env->tlb_fill_exc); +    set_trans_exc_code = true; +    advance = true; +    break; These exceptions came from seeing an early kernel fault, grepping f

Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-31 Thread Ilya Leoshkevich
On Fri, 2023-07-28 at 13:02 -0700, Richard Henderson wrote: > On 7/28/23 12:55, Richard Henderson wrote: > > This solves a problem in which the store to LowCore during tlb_fill > > triggers a clean-page TB invalidation for page0 during translation, > > which results in an assertion failure for lock

Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-29 Thread Claudio Fontana
On 7/28/23 21:55, Richard Henderson wrote: > This solves a problem in which the store to LowCore during tlb_fill > triggers a clean-page TB invalidation for page0 during translation, > which results in an assertion failure for locked pages. > > By delaying the store until after the exception has b

[PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-28 Thread Richard Henderson
This solves a problem in which the store to LowCore during tlb_fill triggers a clean-page TB invalidation for page0 during translation, which results in an assertion failure for locked pages. By delaying the store until after the exception has been raised, we will have unwound the pages locked for

Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-28 Thread Richard Henderson
On 7/28/23 12:55, Richard Henderson wrote: This solves a problem in which the store to LowCore during tlb_fill triggers a clean-page TB invalidation for page0 during translation, which results in an assertion failure for locked pages. By delaying the store until after the exception has been rais