Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-12 Thread Philippe Mathieu-Daudé
On 12/4/23 03:04, Wu, Fei wrote: On 4/11/2023 5:02 PM, Bin Meng wrote: When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. I verified that 'csrr t3, 0x4' in user space didn't cause qemu exit but raised illega

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread Alistair Francis
On Tue, Apr 11, 2023 at 7:03 PM Bin Meng wrote: > > When reading a non-existent CSR QEMU should raise illegal instruction > exception, but currently it just exits due to the g_assert() check. > > This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, > Some comments are also added

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread LIU Zhiwei
On 2023/4/11 17:02, Bin Meng wrote: When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, Some comments are also added to indicate that pre

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread Alistair Francis
On Tue, Apr 11, 2023 at 7:03 PM Bin Meng wrote: > > When reading a non-existent CSR QEMU should raise illegal instruction > exception, but currently it just exits due to the g_assert() check. > > This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, > Some comments are also added

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread Wu, Fei
On 4/11/2023 5:02 PM, Bin Meng wrote: > When reading a non-existent CSR QEMU should raise illegal instruction > exception, but currently it just exits due to the g_assert() check. > I verified that 'csrr t3, 0x4' in user space didn't cause qemu exit but raised illegal instruction after applying th

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread liweiwei
On 2023/4/11 17:02, Bin Meng wrote: When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, Some comments are also added to indicate that pre

Re: [PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread Daniel Henrique Barboza
On 4/11/23 06:02, Bin Meng wrote: When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, Some comments are also added to indicate that pred

[PATCH] target/riscv: Restore the predicate() NULL check behavior

2023-04-11 Thread Bin Meng
When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617, Some comments are also added to indicate that predicate() must be provided for an impleme