Re: [PATCH] target/riscv: Fix page_check_range use in fault-only-first

2023-08-02 Thread Alistair Francis
On Fri, Jul 28, 2023 at 11:34 PM LIU Zhiwei wrote: > > Commit bef6f008b98(accel/tcg: Return bool from page_check_range) converts > integer return value to bool type. However, it wrongly converted the use > of the API in riscv fault-only-first, where page_check_range < = 0, should > be converted to

Re: [PATCH] target/riscv: Fix page_check_range use in fault-only-first

2023-07-31 Thread LIU Zhiwei
On 2023/7/30 5:18, Richard Henderson wrote: On 7/28/23 20:16, LIU Zhiwei wrote: Commit bef6f008b98(accel/tcg: Return bool from page_check_range) converts integer return value to bool type. However, it wrongly converted the use of the API in riscv fault-only-first, where page_check_range < = 0

Re: [PATCH] target/riscv: Fix page_check_range use in fault-only-first

2023-07-29 Thread Richard Henderson
On 7/28/23 20:16, LIU Zhiwei wrote: Commit bef6f008b98(accel/tcg: Return bool from page_check_range) converts integer return value to bool type. However, it wrongly converted the use of the API in riscv fault-only-first, where page_check_range < = 0, should be converted to !page_check_range. Sig

[PATCH] target/riscv: Fix page_check_range use in fault-only-first

2023-07-28 Thread LIU Zhiwei
Commit bef6f008b98(accel/tcg: Return bool from page_check_range) converts integer return value to bool type. However, it wrongly converted the use of the API in riscv fault-only-first, where page_check_range < = 0, should be converted to !page_check_range. Signed-off-by: LIU Zhiwei --- target/ri