Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-02-09 Thread David Gibson
On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: > Use the cs_base field, because it happens to be the same > size as hflags (and MSR, from which hflags is derived). > > In translate, extract most bits from a local hflags variable. > Mark several cases where code generation is *n

Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-01-28 Thread David Gibson
On Sun, Jan 24, 2021 at 09:38:04AM -1000, Richard Henderson wrote: > On 1/23/21 6:46 PM, David Gibson wrote: > > On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: > >> Use the cs_base field, because it happens to be the same > >> size as hflags (and MSR, from which hflags is derive

Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-01-25 Thread Alex Bennée
Richard Henderson writes: > On 1/23/21 6:46 PM, David Gibson wrote: >> On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: >>> Use the cs_base field, because it happens to be the same >>> size as hflags (and MSR, from which hflags is derived). >>> >>> In translate, extract most b

Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-01-24 Thread Richard Henderson
On 1/23/21 6:46 PM, David Gibson wrote: > On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: >> Use the cs_base field, because it happens to be the same >> size as hflags (and MSR, from which hflags is derived). >> >> In translate, extract most bits from a local hflags variable. >>

Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-01-24 Thread Ivan Warren
Richard, Reviewed-by:  Ivan Warren  Thanks a million ! --Ivan On 1/24/2021 4:24 AM, Richard Henderson wrote: Use the cs_base field, because it happens to be the same size as hflags (and MSR, from which hflags is derived). In translate, extract most bits from a local hflags variable. Mark se

Re: [PATCH] target/ppc: Fix truncation of env->hflags

2021-01-23 Thread David Gibson
On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: > Use the cs_base field, because it happens to be the same > size as hflags (and MSR, from which hflags is derived). > > In translate, extract most bits from a local hflags variable. > Mark several cases where code generation is *n

[PATCH] target/ppc: Fix truncation of env->hflags

2021-01-23 Thread Richard Henderson
Use the cs_base field, because it happens to be the same size as hflags (and MSR, from which hflags is derived). In translate, extract most bits from a local hflags variable. Mark several cases where code generation is *not* derived from data stored within the hashed elements of the TranslationBlo