Re: [PATCH] target/mips: Remove JR opcode unused arguments

2021-08-06 Thread Philippe Mathieu-Daudé
On 7/31/21 12:55 AM, Philippe Mathieu-Daudé wrote: > JR opcode (Jump Register) only takes 1 argument, $rs. > JALR (Jump And Link Register) takes 3: $rs, $rd and $hint. > > Commit 6af0bf9c7c3 added their processing into decode_opc() as: > > case 0x08 ... 0x09: /* Jumps */ > gen_compute

Re: [PATCH] target/mips: Remove JR opcode unused arguments

2021-07-31 Thread Richard Henderson
On 7/30/21 12:55 PM, Philippe Mathieu-Daudé wrote: case OPC_JR: -gen_compute_branch(ctx, op1, 4, rs, rd, sa, 4); +gen_compute_branch(ctx, op1, 4, rs, 0, 0, 4); Reviewed-by: Richard Henderson r~

[PATCH] target/mips: Remove JR opcode unused arguments

2021-07-30 Thread Philippe Mathieu-Daudé
JR opcode (Jump Register) only takes 1 argument, $rs. JALR (Jump And Link Register) takes 3: $rs, $rd and $hint. Commit 6af0bf9c7c3 added their processing into decode_opc() as: case 0x08 ... 0x09: /* Jumps */ gen_compute_branch(ctx, op1 | EXT_SPECIAL, rs, rd, sa); having both opcodes