Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-23 Thread Richard Henderson
On 3/20/20 9:56 PM, Jiaxun Yang wrote: > case OPC_SLE_CP2: > -/* > - * ??? Document is unclear: Set FCC[CC]. Does that mean the > - * FD field is the CC field? > - */ > +cond = TCG_COND_LE; > +do_cc_cond: > +{ > +int cc = (ctx->o

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-21 Thread Huacai Chen
On Sat, Mar 21, 2020 at 7:17 PM Jiaxun Yang wrote: > > > > 于 2020年3月21日 GMT+08:00 下午6:57:54, Jiaxun Yang 写到: > > > > > >于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" > > 写到: > >>On 3/21/20 5:56 AM, Jiaxun Yang wrote: > >>> Loongson multimedia condition instructions were previously >

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-21 Thread Jiaxun Yang
于 2020年3月21日 GMT+08:00 下午6:57:54, Jiaxun Yang 写到: > > >于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" > 写到: >>On 3/21/20 5:56 AM, Jiaxun Yang wrote: >>> Loongson multimedia condition instructions were previously >>implemented as >>> write 0 to rd due to lack of documentation. So I j

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-21 Thread Jiaxun Yang
于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" 写到: >On 3/21/20 5:56 AM, Jiaxun Yang wrote: >> Loongson multimedia condition instructions were previously >implemented as >> write 0 to rd due to lack of documentation. So I just confirmed with >Loongson >> about their encoding and imp

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-21 Thread Philippe Mathieu-Daudé
On 3/21/20 5:56 AM, Jiaxun Yang wrote: Loongson multimedia condition instructions were previously implemented as write 0 to rd due to lack of documentation. So I just confirmed with Loongson about their encoding and implemented them correctly. Can you refer to the datasheet in the commit messag

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-21 Thread Aleksandar Markovic
5:58 AM Sub, 21.03.2020. Jiaxun Yang је написао/ла: > > Loongson multimedia condition instructions were previously implemented as > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > about their encoding and implemented them correctly. > > Signed-off-by: Jiaxun Yang >

[PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-20 Thread Jiaxun Yang
Loongson multimedia condition instructions were previously implemented as write 0 to rd due to lack of documentation. So I just confirmed with Loongson about their encoding and implemented them correctly. Signed-off-by: Jiaxun Yang --- target/mips/translate.c | 40 +++