Re: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/30/21 5:33 PM, Richard Henderson wrote: > On 5/29/21 6:05 AM, Philippe Mathieu-Daudé wrote: >> Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), >> Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" >> the byte position field ('bp') is 2 bits, not 3. >

Re: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-30 Thread Richard Henderson
On 5/29/21 6:05 AM, Philippe Mathieu-Daudé wrote: Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" the byte position field ('bp') is 2 bits, not 3. Rev 2.34 has 3 bits, not 2. The mips32 version of bal

Re: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-29 Thread Philippe Mathieu-Daudé
On 5/29/21 3:05 PM, Philippe Mathieu-Daudé wrote: > Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), > Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" > the byte position field ('bp') is 2 bits, not 3. > > Cc: Jia Liu > Fixes: 26690560240 ("target-mips

[PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size

2021-05-29 Thread Philippe Mathieu-Daudé
Per the "MIPS® DSP Module for MIPS64 Architecture" manual (rev 3.02), Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" the byte position field ('bp') is 2 bits, not 3. Cc: Jia Liu Fixes: 26690560240 ("target-mips: Add ASE DSP compare-pick instructions") Signed-off-by: Phili