Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On 04/12/19 16:47, Eduardo Habkost wrote: > On Wed, Dec 04, 2019 at 04:34:45PM +0100, Paolo Bonzini wrote: >> On 04/12/19 16:07, Catherine Ho wrote: Ok, so the problem is that some MSR didn't exist in that version. Which >>> I thought in my platform, the only MSR didn't exist is MSR_IA32_VMX_

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On Wed, Dec 04, 2019 at 04:34:45PM +0100, Paolo Bonzini wrote: > On 04/12/19 16:07, Catherine Ho wrote: > >> Ok, so the problem is that some MSR didn't exist in that version. Which > > I thought in my platform, the only MSR didn't exist is MSR_IA32_VMX_BASIC > > (0x480). If I remove this kvm_msr_e

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On 04/12/19 16:07, Catherine Ho wrote: >> Ok, so the problem is that some MSR didn't exist in that version. Which > I thought in my platform, the only MSR didn't exist is MSR_IA32_VMX_BASIC > (0x480). If I remove this kvm_msr_entry_add(), everything is ok, the guest can > be boot up successfully.

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

Hi Paolo On Wed, 4 Dec 2019 at 21:53, Paolo Bonzini wrote: > > On 04/12/19 14:33, Catherine Ho wrote: > > Hi Paolo > > [sorry to resend it, seems to reply it incorrectly] > > > > On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini > > wrote: > > > > On 04/12/19 09:50, Cat

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On 04/12/19 14:33, Catherine Ho wrote: > Hi Paolo > [sorry to resend it, seems to reply it incorrectly] > > On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini > wrote: > > On 04/12/19 09:50, Catherine Ho wrote: > > Commit 20a78b02d315 ("target/i386: add VMX features")

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

Hi Paolo [sorry to resend it, seems to reply it incorrectly] On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini wrote: > On 04/12/19 09:50, Catherine Ho wrote: > > Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally > > add vmx msr entry although older host kernels don't include them.

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On 04/12/19 09:50, Catherine Ho wrote: > Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally > add vmx msr entry although older host kernels don't include them. > > But old host kernel + newest qemu will cause a qemu crash as follows: > qemu-system-x86_64: error: failed to set MS

[PATCH] target/i386: relax assert when old host kernels don't include msrs

Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally add vmx msr entry although older host kernels don't include them. But old host kernel + newest qemu will cause a qemu crash as follows: qemu-system-x86_64: error: failed to set MSR 0x480 to 0x0 target/i386/kvm.c:2932: kvm_put_ms