Re: [PATCH] target/i386: always create kvmclock device

2020-09-22 Thread Vitaly Kuznetsov
"Dr. David Alan Gilbert" writes: > * Antoine Damhet (antoine.dam...@blade-group.com) wrote: >> On Thu, Sep 17, 2020 at 06:44:10PM +0100, Dr. David Alan Gilbert wrote: >> >> [...] >> >> > > >> > >> > > >> > Shouldn't the old check used when machine type <= 5.1 in order to >> > > >> > avoid >> >

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Dr. David Alan Gilbert
* Antoine Damhet (antoine.dam...@blade-group.com) wrote: > On Thu, Sep 17, 2020 at 06:44:10PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > >> > > > > >> > Shouldn't the old check used when machine type <= 5.1 in order to > > > >> > avoid > > > >> > migration incompatibility ? > > > >>

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Antoine Damhet
On Thu, Sep 17, 2020 at 06:44:10PM +0100, Dr. David Alan Gilbert wrote: [...] > > >> > > > >> > Shouldn't the old check used when machine type <= 5.1 in order to avoid > > >> > migration incompatibility ? > > >> > > >> Hm, when the check fails we just don't create the device and no error is > >

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Paolo Bonzini
On 17/09/20 19:44, Dr. David Alan Gilbert wrote: >> This may happen with an older machine type when the destination is >> running an unfixed QEMU and the source has the fix, right? > Yes I think so. > >> The solution >> would be to introduce a flag for older machine types (or for new ones) >> like

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Paolo Bonzini
On 17/09/20 13:13, Vitaly Kuznetsov wrote: > QEMU's kvmclock device is only created when KVM PV feature bits for > kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are > exposed to the guest. With 'kvm=off' cpu flag the device is not > created and we don't call KVM_GET_CLOCK/KVM_SET_CLOC

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > >> Antoine Damhet writes: > >> > >> > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: > >> >> QEMU's kvmclock device is only created when

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Antoine Damhet
On Thu, Sep 17, 2020 at 03:42:37PM +0100, Dr. David Alan Gilbert wrote: [...] > > > > > > Shouldn't the old check used when machine type <= 5.1 in order to avoid > > > migration incompatibility ? > > > > Hm, when the check fails we just don't create the device and no error is > > reported, so ev

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Vitaly Kuznetsov
"Dr. David Alan Gilbert" writes: > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: >> Antoine Damhet writes: >> >> > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: >> >> QEMU's kvmclock device is only created when KVM PV feature bits for >> >> kvmclock (KVM_FEATURE_CLOCKSOURC

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > Antoine Damhet writes: > > > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: > >> QEMU's kvmclock device is only created when KVM PV feature bits for > >> kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are > >> expos

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Vitaly Kuznetsov
Antoine Damhet writes: > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: >> QEMU's kvmclock device is only created when KVM PV feature bits for >> kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are >> exposed to the guest. With 'kvm=off' cpu flag the device is not >

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Antoine Damhet
On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: > QEMU's kvmclock device is only created when KVM PV feature bits for > kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are > exposed to the guest. With 'kvm=off' cpu flag the device is not > created and we don't call KVM

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Vitaly Kuznetsov
no-re...@patchew.org writes: > Patchew URL: > https://patchew.org/QEMU/20200917111306.819263-1-vkuzn...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > N/A. Internal error while reading log file error: copy-fd: write

Re: [PATCH] target/i386: always create kvmclock device

2020-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200917111306.819263-1-vkuzn...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200917111306

[PATCH] target/i386: always create kvmclock device

2020-09-17 Thread Vitaly Kuznetsov
QEMU's kvmclock device is only created when KVM PV feature bits for kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are exposed to the guest. With 'kvm=off' cpu flag the device is not created and we don't call KVM_GET_CLOCK/KVM_SET_CLOCK upon migration. It was reported that without thes