Re: [PATCH] target/i386: Use cpu_breakpoint_test in breakpoint_handler

2021-07-09 Thread Eduardo Habkost
On Fri, Jul 09, 2021 at 09:00:30AM -0700, Richard Henderson wrote: > Ping. > > On 6/19/21 11:23 PM, Richard Henderson wrote: > > The loop is performing a simple boolean test for the existence > > of a BP_CPU breakpoint at EIP. Plus it gets the iteration wrong, > > if we happen to have a BP_GDB br

Re: [PATCH] target/i386: Use cpu_breakpoint_test in breakpoint_handler

2021-07-09 Thread Richard Henderson
Ping. On 6/19/21 11:23 PM, Richard Henderson wrote: The loop is performing a simple boolean test for the existence of a BP_CPU breakpoint at EIP. Plus it gets the iteration wrong, if we happen to have a BP_GDB breakpoint at the same address. We have a function for this: cpu_breakpoint_test. S

[PATCH] target/i386: Use cpu_breakpoint_test in breakpoint_handler

2021-06-19 Thread Richard Henderson
The loop is performing a simple boolean test for the existence of a BP_CPU breakpoint at EIP. Plus it gets the iteration wrong, if we happen to have a BP_GDB breakpoint at the same address. We have a function for this: cpu_breakpoint_test. Signed-off-by: Richard Henderson --- target/i386/tcg/s