Re: [PATCH] target/i386: Avoid unreachable variable declaration in mmu_translate()

2023-04-06 Thread Philippe Mathieu-Daudé
On 6/4/23 17:59, Peter Maydell wrote: Coverity complains (CID 1507880) that the declaration "int error_code;" in mmu_translate() is unreachable code. Since this is only a declaration, this isn't actually a bug, but: * it's a bear-trap for future changes, because if it was changed to include

Re: [PATCH] target/i386: Avoid unreachable variable declaration in mmu_translate()

2023-04-06 Thread Paolo Bonzini
Queued, thanks. Paolo

[PATCH] target/i386: Avoid unreachable variable declaration in mmu_translate()

2023-04-06 Thread Peter Maydell
Coverity complains (CID 1507880) that the declaration "int error_code;" in mmu_translate() is unreachable code. Since this is only a declaration, this isn't actually a bug, but: * it's a bear-trap for future changes, because if it was changed to include an initialization 'int error_code = foo;'