Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-24 Thread Manish
: "manish.mishra" Subject: [PATCH] target/i386: Always set leaf 0x1f X-Mailer: git-send-email 2.22.3 QEMU does not set 0x1f in case VM does not have extended CPU topology and expects guests to fallback to 0xb. Some versions of windows i.e. windows 10, 11 does not like this behavior and ex

Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-24 Thread Manish Mishra
Thanks Zhao, Igor and Xiaoyao, I have sent v1 for this https://patchwork.ozlabs.org/project/qemu-devel/patch/20240724075226.212882-1-manish.mis...@nutanix.com/. On 23/07/24 8:33 pm, Igor Mammedov wrote: !---| CAUTION: External

Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-23 Thread Zhao Liu
On Wed, Jul 24, 2024 at 08:25:12AM +0800, Xiaoyao Li wrote: > Date: Wed, 24 Jul 2024 08:25:12 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH] target/i386: Always set leaf 0x1f > > On 7/23/2024 10:26 PM, Zhao Liu wrote: > > (+Xiaoyao, whose TDX work may also be related with

Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-23 Thread Xiaoyao Li
2, 2024 at 10:18:59AM +, manish.mishra wrote: Date: Mon, 22 Jul 2024 10:18:59 + From: "manish.mishra" Subject: [PATCH] target/i386: Always set leaf 0x1f X-Mailer: git-send-email 2.22.3 QEMU does not set 0x1f in case VM does not have extended CPU topology and expects guests to f

Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-23 Thread Igor Mammedov
On Mon, 22 Jul 2024 10:18:59 + "manish.mishra" wrote: > QEMU does not set 0x1f in case VM does not have extended CPU topology > and expects guests to fallback to 0xb. Some versions of windows i.e. > windows 10, 11 does not like this behavior and expects this leaf to be ^^

Re: [PATCH] target/i386: Always set leaf 0x1f

2024-07-23 Thread Zhao Liu
(+Xiaoyao, whose TDX work may also be related with this.) Hi Manish, Thanks for your patch! Some comments below. On Mon, Jul 22, 2024 at 10:18:59AM +, manish.mishra wrote: > Date: Mon, 22 Jul 2024 10:18:59 + > From: "manish.mishra" > Subject: [PATCH] target/i386: A

[PATCH] target/i386: Always set leaf 0x1f

2024-07-22 Thread manish.mishra
QEMU does not set 0x1f in case VM does not have extended CPU topology and expects guests to fallback to 0xb. Some versions of windows i.e. windows 10, 11 does not like this behavior and expects this leaf to be populated. This is observed with windows VMs with secure boot, uefi and HyperV role enabl