Re: [PATCH] target/hexagon/idef-parser: Remove self-assignment

2024-07-31 Thread Brian Cain
On 7/31/2024 12:07 PM, Peter Maydell wrote: On Thu, 13 Jul 2023 at 17:21, Brian Cain wrote: -Original Message- From: Anton Johansson Sent: Thursday, July 13, 2023 7:09 AM To: qemu-devel@nongnu.org Cc: Brian Cain ; peter.mayd...@linaro.org Subject: [PATCH] target/hexagon/idef

Re: [PATCH] target/hexagon/idef-parser: Remove self-assignment

2024-07-31 Thread Peter Maydell
On Thu, 13 Jul 2023 at 17:21, Brian Cain wrote: > > > > > -Original Message- > > From: Anton Johansson > > Sent: Thursday, July 13, 2023 7:09 AM > > To: qemu-devel@nongnu.org > > Cc: Brian Cain ; peter.mayd...@linaro.org > > Subject: [P

RE: [PATCH] target/hexagon/idef-parser: Remove self-assignment

2023-07-13 Thread Brian Cain
> -Original Message- > From: Anton Johansson > Sent: Thursday, July 13, 2023 7:09 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; peter.mayd...@linaro.org > Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignment > > WARNING: This email or

Re: [PATCH] target/hexagon/idef-parser: Remove self-assignment

2023-07-13 Thread Philippe Mathieu-Daudé
On 13/7/23 14:08, Anton Johansson via wrote: The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it. Reported-by: Peter Maydell Signed-off-by: Anton Johansson --- target/hexagon/idef-parser/idef-parser.y | 1

[PATCH] target/hexagon/idef-parser: Remove self-assignment

2023-07-13 Thread Anton Johansson via
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it. Reported-by: Peter Maydell Signed-off-by: Anton Johansson --- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-) diff --git a/