Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-05 Thread Fabiano Rosas
Richard Henderson writes: > On 7/4/23 17:44, Peter Maydell wrote: >>> IIUC tcg_enabled(), this guard shouldn't be necessary; if CONFIG_TCG >>> is not defined, tcg_enabled() evaluates to 0, and the compiler should >>> elide the whole block. >> >> IME it's a bit optimistic to assume that the compi

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-05 Thread Richard Henderson
On 7/4/23 17:44, Peter Maydell wrote: IIUC tcg_enabled(), this guard shouldn't be necessary; if CONFIG_TCG is not defined, tcg_enabled() evaluates to 0, and the compiler should elide the whole block. IME it's a bit optimistic to assume that the compiler will always do that, especially with no o

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-04 Thread Philippe Mathieu-Daudé
On 4/7/23 17:44, Peter Maydell wrote: On Tue, 4 Jul 2023 at 16:21, Philippe Mathieu-Daudé wrote: On 28/6/23 18:48, Fabiano Rosas wrote: This code is only relevant when TCG is present in the build. Building with --disable-tcg --enable-xen on an x86 host we get: $ ../configure --target-list=x8

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-04 Thread Peter Maydell
On Tue, 4 Jul 2023 at 16:21, Philippe Mathieu-Daudé wrote: > > On 28/6/23 18:48, Fabiano Rosas wrote: > > This code is only relevant when TCG is present in the build. Building > > with --disable-tcg --enable-xen on an x86 host we get: > > > > $ ../configure --target-list=x86_64-softmmu,aarch64-sof

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-04 Thread Philippe Mathieu-Daudé
On 28/6/23 18:48, Fabiano Rosas wrote: This code is only relevant when TCG is present in the build. Building with --disable-tcg --enable-xen on an x86 host we get: $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg --enable-xen $ make -j$(nproc) ... libqemu-aarch64-softmm

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-07-04 Thread Peter Maydell
On Wed, 28 Jun 2023 at 17:48, Fabiano Rosas wrote: > > This code is only relevant when TCG is present in the build. Building > with --disable-tcg --enable-xen on an x86 host we get: > > $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg > --enable-xen > $ make -j$(nproc) >

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-06-28 Thread Fabiano Rosas
Fabiano Rosas writes: > Philippe Mathieu-Daudé writes: > >> On 28/6/23 18:48, Fabiano Rosas wrote: >>> This code is only relevant when TCG is present in the build. Building >>> with --disable-tcg --enable-xen on an x86 host we get: >>> >>> $ ../configure --target-list=x86_64-softmmu,aarch64-sof

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-06-28 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > On 28/6/23 18:48, Fabiano Rosas wrote: >> This code is only relevant when TCG is present in the build. Building >> with --disable-tcg --enable-xen on an x86 host we get: >> >> $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg >> --enable-

Re: [PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-06-28 Thread Philippe Mathieu-Daudé
On 28/6/23 18:48, Fabiano Rosas wrote: This code is only relevant when TCG is present in the build. Building with --disable-tcg --enable-xen on an x86 host we get: $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg --enable-xen $ make -j$(nproc) ... libqemu-aarch64-softmm

[PATCH] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-06-28 Thread Fabiano Rosas
This code is only relevant when TCG is present in the build. Building with --disable-tcg --enable-xen on an x86 host we get: $ ../configure --target-list=x86_64-softmmu,aarch64-softmmu --disable-tcg --enable-xen $ make -j$(nproc) ... libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub.c.o: in functio