Re: [PATCH] target/arm: Take an exception if PSTATE.IL is set

2021-08-21 Thread Peter Maydell
On Sat, 21 Aug 2021 at 19:59, Richard Henderson wrote: > > > +static inline uint32_t syn_illegalstate(void) > > +{ > > +return EC_ILLEGALSTATE << ARM_EL_EC_SHIFT; > > +} > > I just noticed this should have the IL bit set. Yep. (I remembered about that for the BXJ trap in the other patch, but

Re: [PATCH] target/arm: Take an exception if PSTATE.IL is set

2021-08-21 Thread Richard Henderson
> +static inline uint32_t syn_illegalstate(void) > +{ > +return EC_ILLEGALSTATE << ARM_EL_EC_SHIFT; > +} I just noticed this should have the IL bit set. r~

Re: [PATCH] target/arm: Take an exception if PSTATE.IL is set

2021-08-17 Thread Richard Henderson
On 8/17/21 6:21 AM, Peter Maydell wrote: In v8A, the PSTATE.IL bit is set for various kinds of illegal exception return or mode-change attempts. We already set PSTATE.IL (or its AArch32 equivalent CPSR.IL) in all those cases, but we weren't implementing the part of the behaviour where attempting

[PATCH] target/arm: Take an exception if PSTATE.IL is set

2021-08-17 Thread Peter Maydell
In v8A, the PSTATE.IL bit is set for various kinds of illegal exception return or mode-change attempts. We already set PSTATE.IL (or its AArch32 equivalent CPSR.IL) in all those cases, but we weren't implementing the part of the behaviour where attempting to execute an instruction with PSTATE.IL t