Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-07-05 Thread Peter Maydell
On Fri, 2 Jul 2021 at 16:01, Nick Hudson wrote: > Maybe I’m misreading the ARM ARM and the qemu use of mdscr_el1, but I think > this is good enough / more correct. I’m somewhat confused by AA64 MDSCR_EL1 > vs DBGSCRint vs DBGSCRext, however. Yeah, it is confusing and we generally haven't modeled

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-07-02 Thread Nick Hudson
> On 29 Jun 2021, at 12:50, Peter Maydell wrote: > > On Tue, 29 Jun 2021 at 11:41, Nick Hudson wrote: >> >> >> >>> On 29 Jun 2021, at 10:49, Peter Maydell wrote: >>> >>> On Tue, 29 Jun 2021 at 09:27, wrote: Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- >

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-07-02 Thread Nick Hudson
> On 29 Jun 2021, at 12:50, Peter Maydell wrote: > > On Tue, 29 Jun 2021 at 11:41, Nick Hudson wrote: >> >> >> >>> On 29 Jun 2021, at 10:49, Peter Maydell wrote: >>> >>> On Tue, 29 Jun 2021 at 09:27, wrote: Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- >

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 14:03, Nick Hudson wrote: > > Signed-off-by: Nick Hudson > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index a66c1f0b9e..7267af7924 100644 > --- a/target/arm/helper.c > +++ b

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Richard Henderson
On 6/29/21 1:15 AM, Nick Hudson wrote: { .name = "MDCCSR_EL0", .state = ARM_CP_STATE_BOTH, - .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 1, .opc2 = 0, + .cp = 14, .opc0 = 2, .opc1 = 3, .crn = 0, .crm = 1, .opc2 = 0, Reviewed-by: Richard Henderson r~

[PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Nick Hudson
Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a66c1f0b9e..7267af7924 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6330,7 +6330,7 @@ static const ARMCPRegInfo

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Nick Hudson
> On 29 Jun 2021, at 10:49, Peter Maydell wrote: > > On Tue, 29 Jun 2021 at 09:27, wrote: >> >> Signed-off-by: Nick Hudson >> --- >> target/arm/helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/arm/helper.c b/target/arm/helper.c >> index a66c1f0b9e.

[PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread hnick
Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a66c1f0b9e..7267af7924 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6330,7 +6330,7 @@ static const ARMCPRegInfo

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 11:41, Nick Hudson wrote: > > > > > On 29 Jun 2021, at 10:49, Peter Maydell wrote: > > > > On Tue, 29 Jun 2021 at 09:27, wrote: > >> > >> Signed-off-by: Nick Hudson > >> --- > >> target/arm/helper.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 09:27, wrote: > > Signed-off-by: Nick Hudson > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index a66c1f0b9e..7267af7924 100644 > --- a/target/arm/helper.c > +++ b/target/arm/