Re: [PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

2020-05-18 Thread Randy Yates
Thank you Philippe and the QEMU team! --Randy Philippe Mathieu-Daudé writes: > On 5/15/20 11:26 PM, Richard Henderson wrote: >> On 5/15/20 11:50 AM, Peter Maydell wrote: >>> Using the MSR instruction to write to CPSR.E is deprecated, but it is >>> required to work from any mode including unpriv

[PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

2020-05-18 Thread Peter Maydell
Using the MSR instruction to write to CPSR.E is deprecated, but it is required to work from any mode including unprivileged code. We were incorrectly forbidding usermode code from writing it because CPSR_USER did not include the CPSR_E bit. We use CPSR_USER in only three places: * as the mask of

Re: [PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

2020-05-15 Thread Philippe Mathieu-Daudé
On 5/15/20 11:26 PM, Richard Henderson wrote: On 5/15/20 11:50 AM, Peter Maydell wrote: Using the MSR instruction to write to CPSR.E is deprecated, but it is required to work from any mode including unprivileged code. We were incorrectly forbidding usermode code from writing it because CPSR_USE

Re: [PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

2020-05-15 Thread Richard Henderson
On 5/15/20 11:50 AM, Peter Maydell wrote: > Using the MSR instruction to write to CPSR.E is deprecated, but it is > required to work from any mode including unprivileged code. We were > incorrectly forbidding usermode code from writing it because > CPSR_USER did not include the CPSR_E bit. > > We

[PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

2020-05-15 Thread Peter Maydell
Using the MSR instruction to write to CPSR.E is deprecated, but it is required to work from any mode including unprivileged code. We were incorrectly forbidding usermode code from writing it because CPSR_USER did not include the CPSR_E bit. We use CPSR_USER in only three places: * as the mask of