Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Philippe Mathieu-Daudé
On 8/25/21 2:27 PM, Mark Cave-Ayland wrote: > On 25/08/2021 11:43, Philippe Mathieu-Daudé wrote: > >> +Leon3 maintainers > > Note that despite its presence in CPUSPARCState MXCC isn't part of the > SPARC CPU but defined as part of the sun4m architecture, so I'm not sure > it even exists in LEON3

Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Mark Cave-Ayland
On 25/08/2021 11:43, Philippe Mathieu-Daudé wrote: +Leon3 maintainers Note that despite its presence in CPUSPARCState MXCC isn't part of the SPARC CPU but defined as part of the sun4m architecture, so I'm not sure it even exists in LEON3 (which is likely another reason it was written the way

Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Philippe Mathieu-Daudé
+Leon3 maintainers On Wed, Aug 25, 2021 at 12:39 PM Mark Cave-Ayland wrote: > On 25/08/2021 11:29, Philippe Mathieu-Daudé wrote: > > On 8/25/21 11:51 AM, Mark Cave-Ayland wrote: > >> Commit 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState property") > >> changed > >> the sun4m CPU reset

Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Artyom Tarasenko
On Wed, Aug 25, 2021 at 12:29 PM Philippe Mathieu-Daudé wrote: > > Fixes: 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState > property") > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Philippe Mathieu-Daudé > > diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h > index f

Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Mark Cave-Ayland
On 25/08/2021 11:29, Philippe Mathieu-Daudé wrote: On 8/25/21 11:51 AM, Mark Cave-Ayland wrote: Commit 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState property") changed the sun4m CPU reset code to use the start-powered-off property and so split the creation of the CPU into separate i

Re: [PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Philippe Mathieu-Daudé
On 8/25/21 11:51 AM, Mark Cave-Ayland wrote: > Commit 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState property") > changed > the sun4m CPU reset code to use the start-powered-off property and so split > the > creation of the CPU into separate instantiation and realization phases to > en

[PATCH] sun4m: fix setting CPU id when more than one CPU is present

2021-08-25 Thread Mark Cave-Ayland
Commit 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState property") changed the sun4m CPU reset code to use the start-powered-off property and so split the creation of the CPU into separate instantiation and realization phases to enable the new start-powered-off property to be set. This ac