Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Paolo Bonzini
On 03/09/20 12:22, Thomas Huth wrote: >> Since you didn't remove that conditional, I assume that nothing >> built in a "if not have_block" scenario was relying on the existing >> stub ? Technically there would be a user: scripts/tracetool/backend/log.py -> (qemu_get_thread_id) util/oslib-win32.

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Thomas Huth
On 03/09/2020 09.08, 罗勇刚(Yonggang Luo) wrote: > I am also facing some problem alike: > >   LINK    tests/test-qdev-global-props.exe >   LINK    tests/test-timed-average.exe > C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: > libqemuuti

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Thomas Huth
On 03/09/2020 10.24, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 07:45:03AM +0200, Thomas Huth wrote: >> The linker of MinGW sometimes runs into the following problem: >> >> libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': >> /builds/huth/qemu/build/../util/main-loop.c:3

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 07:45:03AM +0200, Thomas Huth wrote: > The linker of MinGW sometimes runs into the following problem: > > libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': > /builds/huth/qemu/build/../util/main-loop.c:331: multiple definition of > `qemu_fd_register' > l

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-03 Thread Yonggang Luo
I am also facing some problem alike: LINKtests/test-qdev-global-props.exe LINKtests/test-timed-average.exe C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemuutil.a(util_main-loop.c.obj): in function `qemu_notify_event'

Re: [PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-02 Thread Paolo Bonzini
Acked-by: Paolo Bonzini Il gio 3 set 2020, 07:45 Thomas Huth ha scritto: > The linker of MinGW sometimes runs into the following problem: > > libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': > /builds/huth/qemu/build/../util/main-loop.c:331: multiple definition of > `qemu_f

[PATCH] stubs: Move qemu_fd_register stub to util/main-loop.c

2020-09-02 Thread Thomas Huth
The linker of MinGW sometimes runs into the following problem: libqemuutil.a(util_main-loop.c.obj): In function `qemu_fd_register': /builds/huth/qemu/build/../util/main-loop.c:331: multiple definition of `qemu_fd_register' libqemuutil.a(stubs_fd-register.c.obj):/builds/huth/qemu/stubs/fd-register