Re: [PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-17 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 08:23:18PM -0700, Bruce Rogers wrote: > When qemu is built with modules, but a given module doesn't load > qemu should handle that gracefully. When ui-spice-core.so isn't > able to be loaded and qemu is invoked with -display spice-app or > -spice, qemu will dereference a nul

Re: [PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-15 Thread Philippe Mathieu-Daudé
On 2/13/21 4:23 AM, Bruce Rogers wrote: > When qemu is built with modules, but a given module doesn't load > qemu should handle that gracefully. When ui-spice-core.so isn't > able to be loaded and qemu is invoked with -display spice-app or > -spice, qemu will dereference a null pointer. With this c

Re: [PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-14 Thread Marc-André Lureau
On Sat, Feb 13, 2021 at 7:24 AM Bruce Rogers wrote: > When qemu is built with modules, but a given module doesn't load > qemu should handle that gracefully. When ui-spice-core.so isn't > able to be loaded and qemu is invoked with -display spice-app or > -spice, qemu will dereference a null pointe

[PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-12 Thread Bruce Rogers
When qemu is built with modules, but a given module doesn't load qemu should handle that gracefully. When ui-spice-core.so isn't able to be loaded and qemu is invoked with -display spice-app or -spice, qemu will dereference a null pointer. With this change we check the pointer before dereferencing