Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Philippe Mathieu-Daudé
On 9/22/21 13:52, Greg Kurz wrote: On Wed, 22 Sep 2021 13:17:32 +0200 Philippe Mathieu-Daudé wrote: On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Greg Kurz
On Wed, 22 Sep 2021 13:17:32 +0200 Philippe Mathieu-Daudé wrote: > On 9/21/21 21:43, Daniel Henrique Barboza wrote: > > This patch has a handful of modifications for the recent added > > FORM2 support: > > > > - there is no particular reason for both 'lookup_index_table' and > > 'distance_table'

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Daniel Henrique Barboza
On 9/22/21 08:17, Philippe Mathieu-Daudé wrote: On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap, since

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Philippe Mathieu-Daudé
On 9/21/21 21:43, Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap, since their sizes are known right at the start of the fun

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Daniel Henrique Barboza wrote: On 9/22/21 06:51, BALATON Zoltan wrote: On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no par

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Daniel Henrique Barboza
On 9/22/21 06:51, BALATON Zoltan wrote: On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and '

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread BALATON Zoltan
On Wed, 22 Sep 2021, Greg Kurz wrote: On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap,

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-22 Thread Greg Kurz
On Tue, 21 Sep 2021 16:43:47 -0300 Daniel Henrique Barboza wrote: > This patch has a handful of modifications for the recent added > FORM2 support: > > - there is no particular reason for both 'lookup_index_table' and > 'distance_table' to be allocated in the heap, since their sizes are > known

Re: [PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-21 Thread David Gibson
On Tue, Sep 21, 2021 at 04:43:47PM -0300, Daniel Henrique Barboza wrote: > This patch has a handful of modifications for the recent added > FORM2 support: > > - there is no particular reason for both 'lookup_index_table' and > 'distance_table' to be allocated in the heap, since their sizes are > k

[PATCH] spapr_numa.c: fixes in spapr_numa_FORM2_write_rtas_tables()

2021-09-21 Thread Daniel Henrique Barboza
This patch has a handful of modifications for the recent added FORM2 support: - there is no particular reason for both 'lookup_index_table' and 'distance_table' to be allocated in the heap, since their sizes are known right at the start of the function. Use static allocation in them to spare a cou