Re: [PATCH] spapr: Fix Coverity warning while validating nvdimm options

2020-02-27 Thread Shivaprasad G Bhat
On 02/27/2020 05:58 PM, Greg Kurz wrote: On Wed, 26 Feb 2020 13:49:27 +0100 Greg Kurz wrote: -qemu_uuid_parse(uuidstr, &uuid); ... cause a segv in there because uuidstr will be dereferenced at some point without checking if it's NULL. AFAICT there are two scenarios that can cause object_

Re: [PATCH] spapr: Fix Coverity warning while validating nvdimm options

2020-02-27 Thread Greg Kurz
On Wed, 26 Feb 2020 13:49:27 +0100 Greg Kurz wrote: > On Wed, 26 Feb 2020 06:10:38 -0600 > Shivaprasad G Bhat wrote: > > > Fixes Coverity issue, > > CID 1419883: Error handling issues (CHECKED_RETURN) > >Calling "qemu_uuid_parse" without checking return value > > > > nvdimm

Re: [PATCH] spapr: Fix Coverity warning while validating nvdimm options

2020-02-26 Thread Greg Kurz
On Wed, 26 Feb 2020 06:10:38 -0600 Shivaprasad G Bhat wrote: > Fixes Coverity issue, > CID 1419883: Error handling issues (CHECKED_RETURN) >Calling "qemu_uuid_parse" without checking return value > > nvdimm_set_uuid() already verifies if the user provided uuid is valid or > n

Re: [PATCH] spapr: Fix Coverity warning while validating nvdimm options

2020-02-26 Thread Philippe Mathieu-Daudé
Le mer. 26 févr. 2020 13:11, Shivaprasad G Bhat a écrit : > Fixes Coverity issue, > CID 1419883: Error handling issues (CHECKED_RETURN) >Calling "qemu_uuid_parse" without checking return value > > nvdimm_set_uuid() already verifies if the user provided uuid is valid or > not.

[PATCH] spapr: Fix Coverity warning while validating nvdimm options

2020-02-26 Thread Shivaprasad G Bhat
Fixes Coverity issue, CID 1419883: Error handling issues (CHECKED_RETURN) Calling "qemu_uuid_parse" without checking return value nvdimm_set_uuid() already verifies if the user provided uuid is valid or not. So, need to check for the validity during pre-plug validation again. A